Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] #15588 Fixed incorrect image urls in multistore xml sitemap #1

Open
wants to merge 212 commits into
base: 2.3-develop
Choose a base branch
from

Conversation

StevenGuapaBV
Copy link
Owner

Original Pull Request

magento#15689

Description

Added the appEmulation to get the correct image Url for the generated sitemaps. This was needed because the catalog image helper context had incorrect Url data.

Fixed Issues (if relevant)

  1. Images in XML sitemap are always linked to base store in multistore magento/magento2#15588: Images in XML sitemap are always linked to base store in multistore#15588

Manual testing scenarios

  1. In a multistore environment generate multiple sitemaps. Check if the image:loc has the correct base URL for set store.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

julienanquetil and others added 30 commits April 26, 2018 13:14
…ustom source model in the adminhtml doesn't render selected value
Stanislav Idolov and others added 30 commits June 6, 2018 12:40
Accepted Public Pull Requests:
 - magento#15853: Fixed return type hinting in DocBlocks for Wishlist module (by @rogyar)
 - magento#15695: Fixed a couple of typos  (by @dverkade)
 - magento#15833: [Forwardport] Format the javascript code magento#10 (by @chirag-wagento)
 - magento#15755: [Forwardport] Error 500 in Module Manager (by @vijay-wagento)
 - magento#15794: [Forwardport] [Resolved : Styling <select> by changing less variables in Luma theme� (by @hitesh-wagento)
 - magento#15809: [Forwardport] fix: support multiple minisearch widget instances (by @DanielRuf)
 - magento#15558: Fixes in catalog component blocks [2.3-develop] (by @mhauri)
 - magento#15572: [Forwardport] Docblock typo fixes (by @rogyar)
 - magento#15748: [Forwardport] Prevent multiple add-to-cart initializations in case of ajax loaded product listing (by @vijay-wagento)
 - magento#15745: [Forwardport] Fix method name (typo) (by @vijay-wagento)
 - magento#15746: [Forwardport] Resolved : UI Component listing action column outside of screen when... (by @vgelani)
 - magento#15692: Fix minor issues in ui export converter classes (by @dmytro-ch)
 - magento#15649: [Forwardport] Fixes in config module (by @mhauri)
 - magento#15540: fix for Wrong price amount on product page magento#11717 (by @HirokazuNishi)


Fixed GitHub Issues:
 - magento#15192: Module Manager module grid is not working Magento 2.2.4 (reported by @jignesh-baldha) has been fixed in magento#15755 by @vijay-wagento in 2.3-develop branch
   Related commits:
     1. 486f7a7
     2. 1b5d1d1

 - magento#15608: Styling <select> by changing less variables in Luma theme doesn't work as expected (reported by @denistrator) has been fixed in magento#15794 by @hitesh-wagento in 2.3-develop branch
   Related commits:
     1. 9fa6425

 - magento#14153: UI Component listing action column outside of screen when too many columns (reported by @milansimek) has been fixed in magento#15746 by @vgelani in 2.3-develop branch
   Related commits:
     1. 365bfb4

 - magento#11717: Wrong price amount on product page (reported by @HirokazuNishi) has been fixed in magento#15540 by @HirokazuNishi in 2.3-develop branch
   Related commits:
     1. cf05a84
     2. 67a2038
…he cache issue for currencies with no symbol
[TSG] Upporting for 2.3 (pr21) (2.3.0)
…5921

 - Merge Pull Request magento#15921 from DanielRuf/magento2:2.3-develop-PR-port-15871
 - Merged commits:
   1. 4d03776


 - Merge Pull Request magento#15912 from NamrataChangani/magento2:2.3-develop-PR-port-15825
 - Merged commits:
   1. 3782793
…ets. magento#15911

 - Merge Pull Request magento#15911 from NamrataChangani/magento2:2.3-develop-PR-port-15795
 - Merged commits:
   1. fdaf7cb
…e currencies with no symbol magento#15903

 - Merge Pull Request magento#15903 from dmytro-ch/magento2:fix/2.3-cache-issue-for-currencies-with-no-symbol
 - Merged commits:
   1. 23d76ed
Accepted Public Pull Requests:
 - magento#15903: [Forwardport] Complete the fix for cache issue due to the currencies with no symbol (by @dmytro-ch)
 - magento#15911: [Forwardport] Remove double semicolon from the style sheets. (by @namratachangani)
 - magento#15912: [Forwardport] Fixed set template syntax issue (by @namratachangani)
 - magento#15921: [Forwardport] chore: remove unused less import (by @DanielRuf)
 - magento#15867: [Forwardport] Update webapi.xml to fix typo (by @dmytro-ch)
 - magento#15847: [Up-port] check if order data is available to incl ec (by @torhoehn)


Fixed GitHub Issues:
 - magento#12221: Google analytics pageview being triggered twice (reported by @alexhadley) has been fixed in magento#15847 by @torhoehn in 2.3-develop branch
   Related commits:
     1. e46e5a5
Added the appEmulation to get the correct image Url for the generated sitemaps. Context had incorrect Url data.
 48 | ERROR | [x] Opening parenthesis of a multi-line function call must be the last content on the line
placed the stop Emulation in a finally. Now it will always be executed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.